PHPDoc/front-end.php patch

Tim, Here is the first patch after an initial reading over some files. Can you explain exactly what front-end.php should do? And we should discuss this kind of things in private, in the list or both? =) -- Ate´ +++ Antonio CVS .: organiKa :. "We use only recicled bits" floripa@organiKa.com.br http://www.organiKa.com.br Key fingerprint = 9F5B 31B0 C52A 4C4D 3A37 3A9F 7304 2779 5BBE B073

--- pear/PHPDoc/front-end.php Thu Apr 11 13:02:38 2002 +++ front-end.php Fri Apr 12 21:04:22 2002 @@ -1,4 +1,4 @@ -<? +<?php // phpdoc front end // written by tim gallagher // who got tired of manually modifying the index.php file every time he wanted to use phpdoc. @@ -10,6 +10,19 @@ global $_REQUEST; global $_SERVER; +// to avoid warnings .. +if (!isset ($_REQUEST['PHPDOC_appname'])) { + $_REQUEST['PHPDOC_appname'] = ''; +} + +if (!isset ( $_REQUEST['PHPDOC_sourcedir'])) { + $_REQUEST['PHPDOC_sourcedir'] = ''; +} + +if (!isset ( $_REQUEST['PHPDOC_targetdir'])) { + $_REQUEST['PHPDOC_targetdir'] = ''; +} + ?> <form method="POST" action=""> <input type="hidden" name="PHPDOCFE" value="go"> @@ -19,7 +32,7 @@ Directory to store generated documentation.<br><input type="text" name="PHPDOC_targetdir" size="20" value="<?= $_REQUEST['PHPDOC_targetdir']; ?>"><br> Delete Existing Files in Doc Location?<br><INPUT TYPE="checkbox" VALUE="ON" NAME="PHPDOC_deleteFilesOption" CHECKED><br> Template to Use<br><select size="1" name="PHPDOC_selectedTemplate"> - <?PHP + <?php // the list of templates // see PHPDOC/renderer/templates.php foreach ($PHPDOC_templates as $key => $value) @@ -31,10 +44,10 @@ <input type="submit" value="Submit" name="B1"></p> </form> -<? +<?php // exit if we've not gone through this before. -if ($_REQUEST['PHPDOCFE'] != "go" ) { +if (isset ($_REQUEST['PHPDOCFE']) && $_REQUEST['PHPDOCFE'] != "go" ) { echo "</body>\n"; echo "</html>"; exit(); Attachment: [application/pgp-signature] This is a digitally signed message part signature.asc