[PEPr] Comment on Science::Astronomy

From: Date: Thu, 18 Aug 2011 17:44:07 +0000
Subject: [PEPr] Comment on Science::Astronomy
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-54443@lists.php.net to get a copy of this message
I think this is an awesome idea. I recently ported the SGP4/SDP4 code from the Gpredict program for real time satellite tracking and predictions to php, which you can view here: http://github.com/shupp/Predict This code is GPL though, so I couldn't put it in PEAR. (I'm also not modifying the original coding style either, which wouldn't fit into PEAR). But there is a bit of overlap with your package, and perhaps you'll find looking through it useful. Comments are certainly welcome. A few comments on the current state of Science_Astronomy: * The code quality looks very good * I don't think it's necessary to support PHP4, and would like to see the use of PEAR errors removed - use exceptions instead. * I'd rather see class constants than define statements * I've gotten in the habit of using locations (America/Los_Angeles) to get the current gmt offset, which should account for daylight savings time. Perhaps you could add that as an option as well to your rise/set calculations. Better yet, maybe you could accept a DateTime() object that already has the timezone set. Let me know if you'd like any assistance with the package, or help working through any of the above. Cheers, Bill Shupp -- http://pear.php.net/pepr/pepr-proposal-show.php?id=662

« previous php.pear.dev (#54443) next »