Re: problem with submit patch to a feature request into Cache_lite package
| From: | till | Date: | Sun, 28 Aug 2011 17:10:48 +0000 |
| Subject: | Re: problem with submit patch to a feature request into Cache_lite package | ||
| References: | 1 2 3 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-54464@lists.php.net to get a copy of this message | ||
On Sun, Aug 28, 2011 at 12:12 PM, Daniel O'Connor
<daniel.oconnor@gmail.com> wrote:
> Ah; what till said.
> One day we should fix up pearweb to understand a .diff or .patch as being
> text/plain in the majority of cases...
> Otherwise; save your file as .diff.txt and you are sorted
The fixage needs to be in mime-type guessing. It's a huge issue in
many applications.
If pearweb ran on my laptop:
$ file Downloads/02-cache-clean-info.diff
Downloads/02-cache-clean-info.diff: RCS/CVS diff output text
All the guessing essentially depends on a mime-magic file, and I'm not
sure what the best way to approach this is. E.g. creating our own
mime-magic file and feeding it to finfo? That could work, but I'm
hoping someone has -the- one solution to rule them all.
Till