Re: Cache package and Unit Test

Hello ivo, The tests in the Cache_1_5_7-branch have problems: > tests/CacheTest.php:(between 46 and 49) - assertType() will be > removed in PHPUnit 3.6 and should no longer be used. > assertInternalType() should be used for asserting internal types such > as "integer" or "string" whereas assertInstanceOf() should be used > for asserting that an object is an instance of a specified class or > interface. setAllowedOptions() - please add a test when a non-array parameter is used - the Cache/tests directory still exists - msession,phplib,shm: you need to set the errors to some class variable - Cache.php: write in the constructor docblock that $this->container will contain an error if the container cannot be loaded -- Regards/Mit freundlichen Grüßen Christian Weiske -=≡ Geeking around in the name of science since 1982 ≡=-

Attachment: [application/pgp-signature] signature.asc