Re: [PEPr] Comment on Encode::Encode_Base58_GMP

Thanks for the feedback and links Bertrand. I'll start working on these. Some questions: (1) Unit Tests There are already some unit tests in the tarball using PHPUnit. Feel free to take a look and provide feedback. I was wondering if you know of any packages that support Data-Driven Testing where the test data is kept in a separate, language-independent file? I'm using this for Perl but haven't found anything similar in PHP yet. (7) Flickr References I find it ideal to have names for each alphabet since often times there are several alphabets to choose from. I'd prefer not to call it simply 'base58' or 'default' as I'm looking to add Bitcoin's Base58 alphabet and all three (GMP, Flickr, Bitcoin) are different, though equally valid. So far my reading indicates that Flickr may have been the initial user / pubilcizer of the Base58 alphabet using the extended hex alphabet minus [0OIl]. If Flickr is not desirable as a alphabet name, do you have a recommendation? Other encodings tend to use the name of standards or authors, e.g. IETF RFC, z-base-32, Douglas Crockford, etc. Thanks, John On Sat, Nov 19, 2011 at 1:58 AM, Bertrand Mansion <php@mamasam.net> wrote: > Hi, > > Thanks for your proposal, this could be a useful library. I have some > suggestions : > > 1. Use a class > 2. Provide two other versions, one without any extension, one with the BC > math extension which is more popular than gmp > 3. Detect which extension is installed (or not) and use the best version of > the encode/decode functions > 4. Provide unit tests > 5. Provide benchmarks for each version of the encode/decode function > 6. Add documentation > 7. Get rid of references to Flickr > > Have a look at these for other versions : > https://gist.github.com/126883 (no extension) > https://gist.github.com/865912 (tests in python) > http://pastebin.com/vmRQC7ha (bcmath version) > http://code.gogulski.com/bitcoin-php/bitcoin_8inc_source.html > (other > bcmath > version) > > -- > http://pear.php.net/pepr/pepr-proposal-show.php?id=669 >