Re: [pear/Console_Table] a9916d: Add Composer support.
| From: | Jan Schneider | Date: | Sun, 22 Apr 2012 11:57:32 +0000 |
| Subject: | Re: [pear/Console_Table] a9916d: Add Composer support. | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-54930@lists.php.net to get a copy of this message | ||
Please don't merge pull requests for maintained packages, unless they are obvious, trivial bug fixes.
First of all, I'd rather see a general approach for Composer support in PEAR packages than individual pull requests. IMO there is no need to add Composer files. Composer *does* support PEAR packages and translates package.xml dependencies already, no?
Beside that, the package's homepage is *not* on Github. Please revert.
Zitat von Daniel O'Connor <daniel.oconnor@gmail.com>:
Branch: refs/heads/trunk Home: https://github.com/pear/Console_Table Commit: a9916d3950836a1e2b18f219e6c74295323e965a-- Jan Schneider The Horde Project http://www.horde.org/https://github.com/pear/Console_Table/commit/a9916d3950836a1e2b18f219e6c74295323e965aAuthor: Rob Loach <robloach@gmail.com> Date: 2012-04-14 (Sat, 14 Apr 2012) Changed paths:A composer.jsonLog Message: ----------- Add Composer support. Commit: 9b392a61e2042721915f749cec4c0e2e750d9d30https://github.com/pear/Console_Table/commit/9b392a61e2042721915f749cec4c0e2e750d9d30Author: Rob Loach <robloach@gmail.com> Date: 2012-04-14 (Sat, 14 Apr 2012) Changed paths:M composer.jsonLog Message: ----------- Fix the classmap. Commit: b206805971ea3b06dcdccb2dfd660d74446e4df7https://github.com/pear/Console_Table/commit/b206805971ea3b06dcdccb2dfd660d74446e4df7Author: Rob Loach <robloach@gmail.com> Date: 2012-04-14 (Sat, 14 Apr 2012) Changed paths:M composer.jsonLog Message: ----------- Seldaek recommended removing PEAR from the keywords. Commit: 4386550e88bb4aff87ca5b60b036d9ea8ccf9ae7https://github.com/pear/Console_Table/commit/4386550e88bb4aff87ca5b60b036d9ea8ccf9ae7Author: Rob Loach <robloach@gmail.com> Date: 2012-04-19 (Thu, 19 Apr 2012) Changed paths:M composer.jsonLog Message: ----------- Switch the homepage to GitHub. Commit: 40554a34b725053863598ce64d49398c66110244https://github.com/pear/Console_Table/commit/40554a34b725053863598ce64d49398c66110244Author: Daniel O'Connor <daniel.oconnor@gmail.com> Date: 2012-04-21 (Sat, 21 Apr 2012) Changed paths:A composer.jsonLog Message: ----------- Merge pull request #1 from RobLoach/master Composer support for Console_Table Compare: https://github.com/pear/Console_Table/compare/86c8343...40554a3