[PEPr] +1 for Web Services::Services_Apns
| From: | Michael Gauthier | Date: | Fri, 15 Feb 2013 16:30:05 +0000 |
| Subject: | [PEPr] +1 for Web Services::Services_Apns | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-55166@lists.php.net to get a copy of this message | ||
Michael Gauthier (http://pear.php.net/user/gauthierm) has voted +1 on the proposal for Web
Services::Services_Apns.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=689
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=689&handle=gauthierm
Comment:
Looks slick.
1.) Using extension_loaded('mbstring') might make more sense than
function_exists('mb_strlen').
2.) mbstring should be an optional dependency in the package.xml
3.) Due to various PHP bugs and how streams are handled internally, you
might get better performance setting the SOCKET_READ_BYTES to 8192. I'm not
familiar with APNS, so it may be that a larger buffer is never needed as
responses are never > 1024 bytes.