[PEPr] +1 for Authentication::JWT
| From: | Christian Weiske | Date: | Thu, 04 Apr 2013 20:35:21 +0000 |
| Subject: | [PEPr] +1 for Authentication::JWT | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-55216@lists.php.net to get a copy of this message | ||
Christian Weiske (http://pear.php.net/user/cweiske) has voted +1 on the proposal for
Authentication::JWT.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=688
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=688&handle=cweiske
This vote is conditional. The condition is:
- _handleJsonError misses @throws
- tests: testDecodeFromPython assert parameters are in the wrong order
- use exception codes so exceptions can be distinguished programmatically
- I'm not fully happy with the "all static methods" approach, even if it may be fine
here. Smells a bit. Does it make sense to have an JWT object and pre-set the key, so that I can
encode/decode multiple tokens?
- use static:: instead of JWT::
- the tests don't really test the encoding/decoding functionality except the python test. All
others just work by $str = decode(encode($str)) - so I could replace the implementation with
anything, and it would work
- why are all (except one) methods public?
- why is the one method private and not protected?