Re: Re: Crypt_GPG patches / github merge button

From:	Christian Weiske	Date:	Wed, 19 Aug 2015 04:20:53 +0000
Subject:	Re: Re: Crypt_GPG patches / github merge button
References:	1 2	Groups:	php.pear.dev
Request:	Send a blank email to pear-dev+get-55461@lists.php.net to get a copy of this message

Hi Mike, > I got in touch with Alec and giving maintainer status to him. The PRs > look great. Thanks! I saw you used the github merge button. It makes the history very ... unreadable: http://fotostore.cweiske.de/screenshots/2015-08-19%20mail_mime%20git%20merge%20button.png Also see the following blog post describing this very problem: http://blog.spreedly.com/2014/06/24/merge-pull-request-considered-harmful/ It's better to manually rebase patches against master before merging them (and maybe even squashing them into a single commit). -- Regards/Mit freundlichen Grüßen Christian Weiske -=≡ Geeking around in the name of science since 1982 ≡=-

Attachment: [application/pgp-signature] signature.asc