Re: Text_Password static or non-static?

Hello Michael, > I'm making a PR to update the Text_Password package to explicitly > state static methods so it works properly in PHP 7. While updating, I > noticed the documentation and internal code seems to be written > assuming the API is entirely static but the unit tests are written > assuming the API uses class instances. > > For example, the docs say to use: > > Text_Password::create(); > > but the unit tests use: > > $subject = new Text_Password(); > $subject->create(); > > My question to the list is does anyone besides the unit tests use the > non-static API for Text_Password? If $this is not used within Text_Password it's ok to make the methods static. -- Regards/Mit freundlichen Grüßen Christian Weiske -=≡ Geeking around in the name of science since 1982 ≡=-

Attachment: [application/pgp-signature] signature.asc