Re: PR with a test case for pear/OLE
| From: | Ken Guest | Date: | Fri, 06 Oct 2017 07:42:50 +0000 |
| Subject: | Re: PR with a test case for pear/OLE | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-55548@lists.php.net to get a copy of this message | ||
Hi Alexy,
I did the following:
$ git clone git@github.com:sanmai/OLE.git
$ cd OLE
$ git merge origin/tests
$ composer install
$ vendor/bin/phpunit
and it all looks good for me in relation to running the tests :-)
Nice one
Ken
On 6 October 2017 at 02:23, Alexey Kopytko <alexey@kopytko.ru> wrote:
> Hello,
>
> If there's a chance to review and merge this PR, it would help much:
>
> https://github.com/pear/OLE/pull/9
>
> OLE still uses vars in classes - overdue to be refactored. Not the
> thing one wants to do without tests.
>
> I'm not asking for enabling Travis CI on this project, but that will
> be very welcome too.
>
> Thanks.
>
> -Alexey
>
> --
> PEAR Development Mailing List (http://pear.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
--
http://about.me/kenguest/