Re: Net_IMAP
Friends,
I've submitted a simple PR for this first "fix" to use __construct.
Pretty easy.
https://github.com/pear/Net_IMAP/pull/3
I'm not sure what the procedure for these are, beyond the PR -- do I need
to make tests? Try on different versions?
Also, TravisCI failed because it cannot load PHP5.4 -- those details are
here: https://app.travis-ci.com/github/pear/Net_IMAP/builds/251230159
/djb
On Thu, 21 Apr 2022 at 15:47, Ken Guest <kguest@php.net> wrote:
> Hi David
>
> That would be great - thank you, I think for the moment we could go down
> the route of getting patches / PRs via github - if even just for a few
> initial ones, and then set you up with a pear account so you can do
> releases and such.
>
> Kind regards
>
> Ken
>
> On Thu, 21 Apr 2022, 17:06 David Busby, <david.busby@edoceo.com> wrote:
>
>> Hey,
>> This package ( https://pear.php.net/package/Net_IMAP ) show's
>> it's not
>> maintained :( -- but I use it everyday. And now, it's also got some "code
>> rot" issues (like it's using the old constructor pattern).
>>
>> Should I just submit some patches here? I don't have an account on the
>> PEAR site to put stuff there.
>>
>> And also, I've nad to super-class this code to get it to support the
>> XOAUTH stuff that Google IMAP is doing -- so, perhaps I/we could put that
>> code in too?
>>
>> /djb
>>
>
Thread (5 messages)