RE: [PEAR-CVS] cvs: pear /Cache OutputCompression.php
| From: | Christian Stocker | Date: | Thu, 25 Apr 2002 12:02:45 +0000 |
| Subject: | RE: [PEAR-CVS] cvs: pear /Cache OutputCompression.php | ||
| References: | 1 2 | Groups: | php.pear.cvs php.pear.dev |
| Request: | Send a blank email to pear-dev+get-5794@lists.php.net to get a copy of this message | ||
In <LLEGIABELPNEABIBKDFEOEOCCJAA.naoki@avantexchange.com>, Naoki Shima
wrote:
>> could you please explain this?
>> tc
>
> I have submitted this bug report to PEAR-DEV few days ago. The copy of
> the message sent follows:
I'm really really not happy about having a die() in the "middle" of a
class.. We should either make a function printAndDieContent() or you do
the die() by yourself in your code. But having this die within a method,
will certainly confuse some people.
What do others think about that?
chregu
>
> I've deployed PEAR Cache OutputComression on fairly busy site. It worked
> well when I viewed the page via Netscape 6.2. However, when I viewed the
> page using
> IE 6.0/5.0, it just displays white page as when data is not sent to the
> browser.
> When I was hacking the code in Cache/OutputCompression.php, I found out
> that it needed to call exit() just after printContent() does the
> print(). I have modified "print $content;" to "die($content);" in
> printContent().
> I've confirmed that destructor is called even when die() is called
> during the execution by calling
> error_log() to send mail inside the destructor, so I guess the
> garbageCollection() is called properly. There're about 200 processes of
> apache on 5 of each load-balanced servers and it seems working fine for
> 3 days now.
> I could not find any other way to work around this problem. Should I
> commit this change to cvs?
>
> Naoki Shima
> naoki@avantexchange.com
> murahachibu@php.net