Re: [patch] Cache / File container
| From: | Christian Stocker | Date: | Thu, 30 May 2002 22:01:10 +0000 |
| Subject: | Re: [patch] Cache / File container | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-6671@lists.php.net to get a copy of this message | ||
On Thu, 30 May 2002, MARTY Fabien wrote:
> (Christian)
> > Go ahead and commit it, if you think it's the solution (don't wanna be
> > sarcastic about that, i just have no time to check it by myself :) )
>
> Ok, because I think that you don't completly agree, I will commit it as an
> experimental stuff. With a property of file container to decide if we use
> file locking or not (default is false).
Maybe that's an option :) i will test it on my projects as well. But the
reason why i didn't completly agree is that your fix looks very easy and I
don't know, why we didn't include something simple like that back then
when we wrote that class. But i really can't remember the reason, why we
didn't use flock(), and we maybe didn't see the obvious :)
> And I'm going to continue to test it and if it's still correct, I will change
> the default value to true.
yep, do that. and don't wait to long, i also think, locking i badly needed
:)
chregu
--
christian stocker | bitflux GmbH | schöneggstrasse 5 | ch-8004 zurich
phone +41 1 240 56 70 | mobile +41 76 561 88 60 | fax +41 1 240 56 71
http://www.bitflux.ch | chregu@bitflux.ch | gnupg-keyid
0x5CE1DECB