testing pear 3

for those who thought i was already gone :) 8. Cache/graphics.php Graphics.php,v 1.3 2002/05/23 14:18:42 docs: - example has bugs and it`s not working. i thing example should be ready to use - it should display something. such as is - it doesn`t really help - two calls to the same method (cacheImage[Link]) can be really confusing until someone looks inside class code - example is outdated - it is from earlier version of this class, name differs :) its easy to fix but can be confusing for begginers strange things: - typo in example: m5d instead of md5 - array('cache_dir' => $this->cache_dir again in constructor, but this time it should stay like that for security reasons - its better to create directory inside page dir than leting visitors to play around other temp files - when i set image type to gif cacheImage method returns error 'Hmm, is your PHP build with GD support? Can't find any supported types.'. when i change type to png, it is ok. i think this message isn`t right. In this situation 'The build in GD lib does not support the image type $format. Fallback to $supported.' should be returned. - cacheImage contains call to nonexistent function - ob_end. its probably something left from earlier version tests: - it took me about an hour to be able to use this class - i could test only jpg format - pngs were corrupt (i dont know why), gifs warent supported in my gd - example isn`t working - this line: if (!($link = $cache->getImageLink($id, 'gif'))) causes image to be regenerated every time. this should be replaced with: if (count($link = $cache->getImageLink($id, 'gif')) == 0) - generated link isn`t correct - 'graphics' subdirectory is missing summary: - this class is in really bad shape now :( anybody works on that or should i do some fixes? 9. Cache/HTTP_Request HTTP_Request.php,v 1.6 2002/05/29 11:02:32 worked ok 10. Cache/Output and Cache/OutputCompressed ok