Bug #16017 Updated: rule_pear.mk continues cleanly even on failure

ID: 16017 Updated by: pear-dev@lists.php.net Reported By: adconrad@0c3.net -Status: Feedback +Status: No Feedback Bug Type: PEAR related Operating System: Linux PHP Version: 4.1.2 New Comment: No feedback was provided for this bug for over a month, so it is being suspended automatically. If you are able to provide the information that was originally requested, please do so and change the status of the bug back to "Open". Previous Comments: ------------------------------------------------------------------------ [2002-04-14 12:11:36] mj@php.net A new build system has been introduced that caused rules_pear.mk to be removed. Could you please test with a recent snapshot from http://snaps.php.net/ or from CVS, if everything works for you now? - Martin ------------------------------------------------------------------------ [2002-03-12 07:51:00] adconrad@0c3.net build/rules_pear.mk contains a contruct in the install-modules target whereby no matter what happens, the rule will always succeed. From an autobuilding and packaging perspective (as in the case of Debian, for instance), this is horribly broken, as it could lead to empty packages, with no one the wiser. The reason for the "|| true" was so that the rule wouldn't bomb out if there were no modules to install, however it causes the exact opposite problem instead (if there is are supposed to be modules, but they don't get built correctly, we continue on anyway). What follows is a patch to change the behaviour so that we still carry on gracefully if there's no "modules" directory, but if there is one, we will die horribly if installing from it fails: -------- --- rules_pear.mk Tue Mar 13 10:54:38 2001 +++ rules_pear.mk.new Tue Mar 12 05:45:22 2002 @@ -62,11 +62,12 @@ @rm -f $(SUBDIRS) 2>/dev/null || true install-modules: - @test -d modules && \ + if [ -d modules ]; then \ $(mkinstalldirs) $(moduledir) && \ echo "installing shared modules into $(moduledir)" && \ rm -f modules/*.la && \ - cp modules/* $(moduledir) || true + cp modules/* $(moduledir); \ + fi include $(builddir)/.deps ----------- ... Adam Conrad (the new Debian php4 maintainer) ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=16017&edit=1