[patch] Image/GraphViz
| From: | Carsten Saathoff | Date: | Mon, 17 Jun 2002 21:38:23 +0000 |
| Subject: | [patch] Image/GraphViz | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-7156@lists.php.net to get a copy of this message | ||
Hi,
I am just playing around with Image/GraphViz and I found a bug (or at
least I think, it's a bug). It's not possible to define an edge between
two nodes without giving the edge at least one attribute. This is
contradictory to the definition of an edge. So I fixed this problem. I'll
attach the diff.
Greetings
Carsten
--
Carsten Saathoff ...powered by Linux ICQ #52558095
The gods are great, I am the greatest!
(Borknagar)
Index: GraphViz.php =================================================================== RCS file: /repository/pear/Image_GraphViz/GraphViz.php,v retrieving revision 1.2 diff -u -b -u -1 -r1.2 GraphViz.php --- GraphViz.php 5 Apr 2002 13:47:35 -0000 1.2 +++ GraphViz.php 17 Jun 2002 21:02:44 -0000 @@ -318,3 +318,2 @@ - if (!empty($attribute_list)) { $parsed_graph .= '"' . @@ -323,6 +322,9 @@ addslashes(stripslashes($to)) . - '" [ ' . + '"'; + if (!empty($attribute_list)) { + $parsed_graph .= ' [ ' . implode(',', $attribute_list) . - " ];\n"; + " ]"; } + $parsed_graph .= ';'; }
Index: GraphViz.php =================================================================== RCS file: /repository/pear/Image_GraphViz/GraphViz.php,v retrieving revision 1.2 diff -u -b -u -1 -r1.2 GraphViz.php --- GraphViz.php 5 Apr 2002 13:47:35 -0000 1.2 +++ GraphViz.php 17 Jun 2002 21:02:44 -0000 @@ -318,3 +318,2 @@ - if (!empty($attribute_list)) { $parsed_graph .= '"' . @@ -323,6 +322,9 @@ addslashes(stripslashes($to)) . - '" [ ' . + '"'; + if (!empty($attribute_list)) { + $parsed_graph .= ' [ ' . implode(',', $attribute_list) . - " ];\n"; + " ]"; } + $parsed_graph .= ';'; }