Re: cvs: pear /DBA DBA.php DBA_Builtin.php DBA_Compat.php DBA_Relational.php DBA_Simple.php DBA_Table.php package.xml /DBA/tests benchmark.php
graph_template simple.php

Brent Cook wrote:

The DBA drivers, the ones using trigger_error and returning booleans, are most useful when they are embedded into a higher-level class. I'll be sure to use raiseError on the higher levels; Table and Relational. Your driver classes can be used by other package developers and users too. Using trigger_error is not compliant to the PEAR standards and not the expected behavior of PEAR classes.

b) run phpdoc over your code - you will get a lot of warnings. Note: markup public functions with @access private

Thanks, I will. Are you sure that public functions are supposed to be marked with access private?

Ups, i mean: @access public