more MDB hacking

Attached is a patch to fix LOB support in MDB pgsql driver - it now passes the LOB tests in driver_test.php. This means that the pgsql driver now passes all the tests in driver_test.php, hence I would appreciate it if anyone had time to bang on it and check for bugs. Right now I'll be looking through for CS stuff. Also how strictly should we enforce contracts, e.g. // }}} // {{{ fetch() /** * fetch value from a result set * * @param resource $result result identifier * @param int $row number of the row where the data can be found * @param int $field field number where the data can be found * * @return mixed string on success, a DB error on failure * * @access public */ function fetch($result, $row, $field) Should we check is_resource($result), is_int($row), is_int($field) and return errors or do we let the bad data go down to the native functions to return errors back up? I vote for enforcing the contract. Paul -- ----------------------------------------------------------------- Paul Cooper | Tel: 0121 331 7858 Senior Programmer and Database Engineer | Fax: 0121 331 7859 UCEcom | mailto:pgc@ucecom.com University of Central England | http://www.ucecom.com Birmingham, B4 7DX | -----------------------------------------------------------------

Attachment: [text/x-patch] pgsql.diff