RE: [PEAR-DEV] Re: problem with System.php under Zend 2
| From: | Andi Gutmans | Date: | Fri, 16 Aug 2002 16:08:23 +0000 |
| Subject: | RE: [PEAR-DEV] Re: problem with System.php under Zend 2 | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-8461@lists.php.net to get a copy of this message | ||
You'll have to call main::mkdir().
I think considering that this usually isn't the case (more often then not you'll prefer to call the method) and that it's kind of slow having to always do two hash lookups I think it should stay the way it is.
Andi
At 05:47 PM 8/10/2002 +0100, James Cox wrote:
Actually, this kind of sucks, and is a big black hole for BC: <@imajes> cox: we should really fix that little problem within ZE2... or at least, have a thing which says if in method, and function exists, call function not method <@cox> imajes: that has sense <@imajes> but to be honest <@imajes> I don't like this change to ze2 <@cox> otherwise a lot of BC will be broken <@imajes> cox: agreed <@imajes> cox: I don't see the problem of class::method <@imajes> if, and only if, !function_exists, then calling the method directly should be fine. <@cox> tell where to vote +1 for that ;-) from irc. opinions? -- james Brad Bulger wrote:System.php has a method named mkDir that makes calls to mkdir() - those are supposed to call the built-in PHP mkdir() function, but the ZE2 changes are causing it to call itself instead, unti it falls over. In ZE2 you can fix that with just main::mkdir(), but then that doesn't work with the current version. Only thing I could think of that worked in both was call_user_func('mkdir',$dirname,$umask), which seems kind of ewww. Anyways, that diff is attached if it's of use - just wanted to mention the problem.Great, thanks for spoting that out. The patch has been commited. Tomas V.V.Cox -- PEAR Development Mailing List (http://pear.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PEAR Development Mailing List (http://pear.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php