Re: PHPDoc bugfix

Hello, thank you for this patch, I committed it to CVS. Derick Jeroen Derks wrote:

Hi there, I have recently started to use PHPDoc intensively, it comes in very handy! Currently I'm generating documentation where I have subdirectories which are not readable by my webserver. Unfortunately in filehandler/PhpdocFileHandler.php this results in the getFilesInDirectory() function to return an empty array, which in turn resets the $files array, so that it is left empty. A simple fix would be the following patch (against the current CVS version 1.3): Index: filehandler/PhpdocFileHandler.php =================================================================== RCS file: /repository/pear/PHPDoc/filehandler/PhpdocFileHandler.php,v retrieving revision 1.3 diff -c -3 -r1.3 PhpdocFileHandler.php *** filehandler/PhpdocFileHandler.php 26 Jul 2002 14:49:39 -0000 1.3 --- filehandler/PhpdocFileHandler.php 23 Aug 2002 12:53:41 -0000 *************** *** 179,185 ****

          $dh = @opendir($directory);
          if (!$dh) {
              $this->err[] = new PhpdocError("Can't open '$directory' for reading.", __FILE__, __LINE__);
!             return array();
          }
                    while ($file = readdir($dh)) {

--- 179,185 ----

          $dh = @opendir($directory);
          if (!$dh) {
              $this->err[] = new PhpdocError("Can't open '$directory' for reading.", __FILE__, __LINE__);
!             return $files;
          }
                    while ($file = readdir($dh)) {

Kind regards, Jeroen Derks