Re: a cookie handling patch for HTTP_Request

On Wed Sep 11, 2002 at 03:3351PM +0400, Alexey Borzov wrote: > I tried to use HTTP_Request/HTTP_Response classes in my project and > found out that they did not work quite well with cookies set in server's > response. HTTP_Response kept all response headers in associative array > (header name => header value). As the response can contain _multiple_ > Set-Cookie headers, their values got overwritten. Besides, there > was no easy way to add cookies to request or to extract their > values from response. > > This patch adds two methods: addCookie() and getResponseCookies() > to HTTP_Request class and Set-Cookie parsing logic to > HTTP_Response's constructor. Cookies are kept (and returned via > getResponseCookies()) in an array with numerical keys (as multiple > cookies can have the same name). The patch looks fine for me. What do the maintainers think? -- - Martin Martin Jansen http://martinjansen.com/