Re: Fwd: Re: [PEAR-QA] \n after ?> CS Stupid?

Daniel Convissor wrote: > Hi: > > [I forgot to cc doc list, which got brought in by Arunaud (you little > instigator, you! :)) --dc] > > > ----- Forwarded message from Daniel Convissor <danielc@analysisandsolutions.com> ----- > > From: Daniel Convissor <danielc@analysisandsolutions.com> > To: PEAR QA List <pear-qa@lists.php.net> > Date: Sun, 18 Sep 2005 13:52:58 -0400 > Subject: Re: [PEAR-QA] \n after ?> CS Stupid? > > Hi: > > On Sun, Sep 18, 2005 at 07:48:18PM +0200, Arnaud Limbourg wrote: > >>I agree it should be removed, I usually don't have one and even remove >>it when I see one. I have no idea why it is there. > > > It's been discussed a few times. This is for two reasons. > > Unix files are supposed to have an \n after the last character (or > whatever you want to call it). > > If they're not there, some editors add them automatically. So, having > them there all the time reduces the silly "No newline at end of file" > messages found frequently in CVS commits. Every editor allows this to be configurable. CS should be to make the code more readable and to make it work better. This does neither. I have reservations also about requiring the file-level docblock, as this is probably something that should be fixed in phpDocumentor (for instance, allow it to assume PEAR CS which means all things in a file are in the same package) Now that PEAR 1.4.0 is out (shortly) I will be able to address phpDocumentor-related issues better, and solve some of the more persisten problems. Hopefully. Greg