Re: HTML_Page (or Page2) and framesets

Matte Edens wrote:

I've used the new files and they look great. I have one wish though. I'd like to have a way of adding custom attributes to the frameset/frame tags. Especially the frameset tags. Or at least a way of setting the "border" and "frameborder" attributes of the frameset and frame tag. Those are the only way to control the border status of a frame. And while it doesn't validate as true XHTML, webdevelopers who use frames have come to accept that frames (well at least good looking frames) don't validate. At least I have.

Since the frame/frameset classes extend HTML_Common, the method setAttributes() and updateAttributes() (or something to that effect) are available. All attributes for the frame/frameset are stored using this mechanism. However, I do like the idea of having shortcut methods for often used features. And since the border attribute is certainly available in pre-XHTML code, I think it's pretty clear that it should be supported :-) And since the frameset isn't as available in modular XHTML (<= 1.1), I don't think anyone will bother about it ;-) I'll see what I can do about it :-) Thanks again for the input... Klaus

perhaps a ... $page->frameset->setBorder(int borderWidth) this would set both the "border" and "frameborder" attributes since you need both for Mozilla & IE to work, if I remember correctly. matte -----Original Message----- From: Klaus Guenther [mailto:klaus@capitalfocus.org] Sent: Thu 6/24/2004 10:23 AM To: Matte Edens Cc: pear-general@lists.php.net Subject: Re: [PEAR] HTML_Page (or Page2) and framesets Klaus Guenther wrote:

Matte Edens wrote:

off the top of my head couldn't there be something like this (until there's an HTML_Frameset package) ... $frameset = $page->createFrameset(array $attributes); $frameset->addFrame(array $attributes); $page->addBodyContent('To view this page properly, your browser must support framesets.'); $page->addFrameset($frameset);

Today I'll try to write HTML_Page2_Frameset, an instance of which will be located at $page->frameset, and it can be nested at will.

Check out CVS. There is an example in there, too. Klaus