Re: Re: Structures_DataGrid_Renderer_HTMLTable QUERY_STRING 'feature' (read bug! ;) )
| From: | Justin Patrin | Date: | Fri, 28 Jan 2005 18:52:44 +0000 |
| Subject: | Re: Re: Structures_DataGrid_Renderer_HTMLTable QUERY_STRING 'feature' (read bug! ;) ) | ||
| References: | 1 2 | Groups: | php.pear.general |
| Request: | Send a blank email to pear-general+get-17251@lists.php.net to get a copy of this message | ||
On Fri, 28 Jan 2005 13:44:41 -0500, Andrew Nagy <asnagy@webitecture.org> wrote:
> Ian P. Christian wrote:
> > Line 350:
> >
> > if (stristr($element, $this->_dg->requestPrefix . 'orderBy')) {
> > $url .= $this->_dg->requestPrefix . 'orderBy=' .
> > $column->orderBy;
> > $orderByExists = true;
> > } elseif (stristr($element, $this->_dg->requestPrefix . 'direction')) {
> > $url .= $direction;
> > } elseif (stristr($element, $this->_dg->requestPrefix . 'page') &&
> > $this->sortingResetsPaging) {
> > $url .= $this->_dg->requestPrefix . 'page=1';
> > } else {
> > $url .= $element;
> > }
> >
> >
> > You're doing 'strstr', so if any other paramters contain 'page',
> > they are
> > ignored :)
> >
> > Kind Regards,
> >
>
> What bug are you referring to? What is wrong with this block of code?
>
He's saying that if you have 'pageType=simple' or similar in the
request prefix this code will assume you have 'page' set when you do
not.
--
Justin Patrin