Re: Bug in Benchmark_Profiler

Hi ! Sascha Eissler wrote:

[This message has been brought to you via pear.php.net.] Hi, i found a Bug in you Benchmark_Profiler. Please use the bug system : you request can then be followed and anyway, some others as the listed maintainers possibly work on the packages ... so make it public:

just click the "Bugs" tab in package's page, search if not allready there (and perhaps corrected) and if not create a new one. It's the best place to propose some patch.

Your private Member "_auto" isn´t used correctly. er ... you mean PEAR's ones ?

I keep "my" private members with me :)

wrong: function Benchmark_Profiler($auto = FALSE) {

       $this->auto = $auto;

       if ($this->auto) {
           $this->start();
       }

       $this->PEAR();

} function _Benchmark_Profiler() {

       if (isset($this->auto)) {
           $this->stop();
           $this->display();
       }

} corrected: function Benchmark_Profiler($auto = FALSE) {

       $this->_auto = $auto;

       if ($this->_auto) {
           $this->start();
       }

       $this->PEAR();

} function _Benchmark_Profiler() {

       if ($this->_auto) {
           $this->stop();
           $this->display();
       }

} Could you please correct this OK, it's corrected in CVS ... so, it's a little bit yours too now :)

and deploy an new release. No, this typo does not affect the functionning of the package.

We will make a new release when some major bugs corrected or enhancements done. I just took over the package from Sebastian and I'm currently studying the features which could be of interest. As pointed out by Sebastian perhaps a refactoring of Benchmark_Iterate, Davey asked for some basic output, more generally some standard renderers could be offered extra (included after bench), a further project is tout integrate resources usages in the benchmark as per my proposal Benchmark_Resource. The list is open ... Thanks for your help anyway ! Bis bald. -- bertrand Gugger http://toggg.com/