getRow parameter order

From: Date: Thu, 06 Sep 2001 01:23:52 +0000
Subject: getRow parameter order
Groups: php.pear.general 
Request: Send a blank email to pear-general+get-302@lists.php.net to get a copy of this message
Hi, I'm new to the list, but have been using Pear::DB since January. (BTW, only with postgres - I'd be interested to hear troubles people had moving their code to other databases). Can someone confirm the order of the parameters for getRow() (DB/common.php)? In V1.62 (the one that comes with 4.0.6) the 2nd parameter is $fetchmode, and $params is the 3rd param. But in 1.65 (that came with the very nice phpwin 4.0.7-dev package), $params is the 2nd parameter and $fetchmode is 3rd. But the comments above it still list $fetchmode second. Is this just a bug in 1.65, or a deliberate change? Either way, but especially if deliberate, "assert(is_array($params))" at the top of getRow() would be nice, so it doesn't quietly break existing code. What is the thinking behind the "settype($params, "array");" currently in there? Darren

« previous php.pear.general (#302) next »