RE: [PEAR-QA] BC check on release upload
| From: | Lukas Smith | Date: | Wed, 17 Sep 2003 07:37:35 +0000 |
| Subject: | RE: [PEAR-QA] BC check on release upload | ||
| References: | 1 | Groups: | php.pear.qa |
| Request: | Send a blank email to pear-qa+get-188@lists.php.net to get a copy of this message | ||
> From: Pierre-Alain Joye [mailto:paj@pearfr.org]
> Sent: Wednesday, September 17, 2003 9:34 AM
> While discussion about Log 1.7.0 which introduces a BC break between 2
> releases with the same major version number. I started to work on a
> interface checker.
>
> It checks the functions/classes/class::method between the uploaded
> release and the previous release, only if the major version number is
> the same.
>
> A release is rejected if:
> - A Class has been droped
> - a function or method has been droped
>
> What should be good to add:
> - function/method arguments
> - if optionnals arguments have been added, there is no BC issue
> (obviously only appended and not prepended or somewhere between
> existing arguments)- if required arguments have been added, the
> release is rejected
>
> That requires to add arguments to the "provides" tag, with an
optionnal
> flag. I plan to add it asap to pearweb.
>
> Comments?
This is very good stuff.
However what about private methods, classes etc?
Therefore I would not rejected the release but issue a warning
containing the differences that were detected. The maintainer then needs
to explicitly say: "no I still want to upload because I know what I am
doing".
Regards,
Lukas