Re[2]: [PEAR-QA] Re: File_SearchReplace
| From: | anatoly techtonik | Date: | Fri, 07 Jan 2005 01:46:08 +0000 |
| Subject: | Re[2]: [PEAR-QA] Re: File_SearchReplace | ||
| References: | 1 2 3 | Groups: | php.pear.qa |
| Request: | Send a blank email to pear-qa+get-2303@lists.php.net to get a copy of this message | ||
Hello Mika,
From Thursday, January 6, 2005, 8:13:40 PM, you wrote:
>> > File_SearchReplace looks orphaned, what is your position regarding the
>> > package ?
>> AFAIR, Mika made some updates recently...
MT> It was File_Find :)
BTW,
--- Find_old.php 2005-01-07 02:42:14.000000000 +0200
+++ Find.php 2005-01-07 03:14:32.000000000 +0200
@@ -199,9 +199,7 @@
{
/* if called statically */
- /* TODO: this will fail if File_Find::search() is called inside */
- /* instance of some other object */
- if (!isset($this)) {
+ if (!isset($this) || !is_a($this, "File_Find") {
$obj = &new File_Find();
return $obj->search($pattern, $directory, $type, $fullpath);
} else {
P.S. Tests are required some modifications too, because there is no
such root /tmp on windows
t
--