Re: Heavy need for action at Pear::Date
| From: | tmp | Date: | Wed, 19 Jan 2005 11:40:51 +0000 |
| Subject: | Re: Heavy need for action at Pear::Date | ||
| References: | 1 2 | Groups: | php.pear.qa |
| Request: | Send a blank email to pear-qa+get-2342@lists.php.net to get a copy of this message | ||
> I already replied in the bug tracker.
Yes, I can see a reply from late august 2004. In your reply you wrote:
> We should restore the TZ var to their original status.
As I have noted in the comments, this is not a thread safe solution. The
arguments has to be cloned in order to take care of the critical region.
> Second fixing this issue without BC and keeping TS issues is not a
> quick task.
I don't know what you mean with "TS". Regarding to BC, there are two cases:
* php4: Objects are here parsed by value and is therefore automatically
cloned. Fixing the bug (by cloning arguments as the first thing in the
function body) will therefore leave an equivalent and functioning
implementation - regarding to php4.
* php5: Objects are parsed by reference. By cloning the arguments we
obtain a situation equivalent to the php4-case, which does not have the
problem.
In both the php4 and php5 cases I see no BC issues.
If you are en lack of time I will gladly provide a patch, if this can
boost a new release, with a bugfix, soon.
Regards