Re: New maintainer for SQL_Parser
| From: | Helgi Þormar Þobjörnsson | Date: | Sun, 05 Nov 2006 13:29:36 +0000 |
| Subject: | Re: New maintainer for SQL_Parser | ||
| References: | 1 | Groups: | php.pear.qa |
| Request: | Send a blank email to pear-qa+get-4041@lists.php.net to get a copy of this message | ||
On Sat, 04 Nov 2006 16:50:50 -0500, Daniel Rousseau wrote:
Hi Daniel
> I would like to apply as the new maintainer for SQP_Parser package.
>
> First of all, I downloaded the code and made many improvements over what
> I found. I really think I improved the code to the point that all the
> pending bug reports are resolved.
>
> I also added test cases over the existing test suite, tests that my code
> pass. I would say that the code is very near industrial quality, and
> that it could parse almost any SQL declaration.
>
> I am myself an electrical engineer of 25 years experience. I am now
> developping a web site, and it is in that regard that I found I needed a
> parser to analyse the SQL declarations I encountered. Realizing it was
> incomplete, I just then debugged, improved and tested the source to the
> point it almost doubled in size.
Sounds good but could you show us a diff between your changes and current
trunk ?
diff -u would be preferred and that you'd link it somewhere on the web
instead of pasting it here.
Thanks
Helgi
--
There are no stupid questions, only stupid people