Re: Patches

From: Date: Sun, 08 Feb 2004 08:43:59 +0000
Subject: Re: Patches
References: 1  Groups: php.pear.qa 
Request: Send a blank email to pear-qa+get-502@lists.php.net to get a copy of this message
Mika Tuupola wrote:
On Fri, 6 Feb 2004, Mika Tuupola wrote:
XML_DTD http://pear.php.net/bugs/bug.php?id=168
XML_Tree http://pear.php.net/bugs/bug.php?id=89
And the same as attachments. I have these just waiting for commit in my checkout. ------------------------------------------------------------------------
--- Node.php.org        2004-02-06 12:42:38.080016000 +0200
+++ Node.php    2004-02-06 12:42:44.980045000 +0200
Hmm this looks like a BC break. However 2.0 seems to be in beta with no stable release as of yet. Anyways I am not sure why things where done the way they were. But it looks very deliberate. So all in all maybe an option would be more appropriate?
--- DTD.php     2004-02-06 12:14:51.039983000 +0200
+++ DTD.php.new 2004-02-06 12:14:15.979992000 +0200
This looks like a fairly safe correction. I am not sure about how to go about thing now. Both bugs seem to date back to october. I think since both packages are still before their first stable release in the relevant major version cycle. So fixing the code in CVS seems safe to me. Dunno about firing a release though as I dont know how much development aside from that was done since the last release. regards, Lukas Smith smith@backendmedia.com _______________________________ BackendMedia www.backendmedia.com berlin@backendmedia.com Linn Zwoch Smith GbR Pariser Str. 44 D-10707 Berlin Tel +49 30 83 22 50 00 Fax +49 30 83 22 50 07

« previous php.pear.qa (#502) next »