Re: Unit tests; XML_RPC2, etc

Hey Sergio, I fixed up the last of the tests just tonight, and found http://bugs.php.net/bug.php?id=47263 If you've got time, can you review some of the changes and just make sure I haven't done any crazy things :) The tests should now: - Skip if extensions aren't available - Always think in UTC rather than the local timezone - No longer hit PEAR's XML rpc services, which are dead. Ditto time.xmlrpc.com. On Mon, Oct 27, 2008 at 10:51 PM, Sérgio Carvalho <sergiosgc@gmail.com>wrote: > > If I understand correctly, you are only adding SKIPIF sections to tests > dependent on extensions. That is perfectly fine by me. Many thanks for the > cleanup help. > > Kind regards, > - > Sérgio Carvalho > > > Daniel O'Connor wrote: > >> Hey all, >> Would any of you have any concerns if I applied fixes for: >> http://pear.php.net/bugs/bug.php?id=14822 >> >> ? >> >> Just trying to get a workable set of unit tests for PEAR, and I'm pretty >> close! >> Tests: 3202, Assertions: 20595, Failures: 187, Errors: 48, Incomplete: 86. >> >> If I can just get some of the XML_RPC2 tests skipping when the required >> extensions aren't there, we'll see an even better reduction in failures :) >> >> >> >