Re: patch to Mail_Mime

From: Date: Fri, 24 Jul 2009 01:18:24 +0000
Subject: Re: patch to Mail_Mime
References: 1 2 3  Groups: php.pear.qa 
Request: Send a blank email to pear-qa+get-5372@lists.php.net to get a copy of this message
Curiosity hat: Does that actually make a significant measurable difference? (Icanhasbenchmarks?) I know there's a lot of slowness in mail_mime encode under certain circumstances/one of the encoding methods, and every time I got to hunting it down with wincachegrind I couldn't ever quite pin it down (though I have vague memories of nasty regex around the place). implode() vs concat doesn't feel like it would be a massive difference (though I'm probably somewhat wrong) On Fri, Jul 24, 2009 at 12:19 AM, Alan Knowles <mailinglist@akbkhome.com>wrote: > Patch is fine - apart from minor CS issues - it just concat's the string > inline rather than imploding an array of strings.. > > Regards > Alan > >

« previous php.pear.qa (#5372) next »