Re: Net_SMS rewritten package offer for review(draft version)

On Fri, Aug 28, 2009 at 3:03 AM, Fedyashev Nikita <loci.master@gmail.com>wrote: > >>Daniel O'Connor <daniel.oconnor@gmail.com> > >>|| I think something about 85% of production-ready(docs, code > conventions etc.) > >>|| code is done. > >>Nice! :) > >>Links? > > Sorry, for delay. > > Here is the link: > svn checkout > http://mytestrepo.googlecode.com/svn/trunk/mytestrepo-read-only > > > This is a draft version. For ex - file doc/class docs in some places I've > just typed temporary dummy value just to get rid of CodeSniffer's error > level messages. > I want to know your thoughts about it. > > This is my first experience in working with PEAR. > If you have some question about archicture decisions I've made - I can > explain. For some parts I've tried several solutions until find the better > one(IMHO). All was driven by unit-tests, which was absent when I started > working on the project. > > Thanks, in advance > > >>>>Hello guys > >>>>>>if you have not been involved in PEAR prior to that, it is a good > idea > to write a few words about you and your motivations. > >>>>I have 4+ yrs of professional PHP development using T.D.D.(2 yrs), > Design patterns and incremental refactoring. > >>>>My blog - realitydrivendeveloper.com > >>>>My primary motivation is to become an official open-source developer of > this package, so I can add this info to my CV. > >>>>Secondary motivation is to write good code which is useful for other > >>>>I've already submitted one patch for Net_SMS which was accepted by > Chuck > Hagenbuch - http://bugs.horde.org/ticket/8439 > >>>>I'm not very proud of this patch, but there were basic Net_SMS > framework > restrictions which forced me to make it look alike other > wrappers/operators. > >>>> > >>>>Now I'm finishing major Net_SMS refactoring. > >>>> > >>>>Changelog: > >>>> * unit-tests added for basic functions of all wrappers > >>>> * Sent messages iterator mechanism was completely reworked > >>>> * Error handling mechanism was reworked > >>>> * Lots of refactoring of procedural to OO style code was > introduced(writen in test-first style) > >>>> * I'm finishing transition to PHP5 PEAR code conventions and > polishing phpdocs for each function > >>>> > >>>>PHPUnit report: > >>>> > >>>>phpunit: > >>>> [exec] PHPUnit 3.3.15 by Sebastian Bergmann. > >>>> [exec] > >>>> [exec] ................................... > >>>> [exec] > >>>> [exec] Time: 0 seconds > >>>> [exec] > >>>> OK (35 tests, 76 assertions) > > >>>>I think something about 85% of production-ready(docs, code conventions > etc.) code is done. > > >>>>I've asked at IRC channel what should I do next and they say that the > first thing I've to do is to write to QA list about my intentions and to > get > some feedback of you about that. > > >>>>Maybe I should submit draft version of reworked Net_SMS so you can know > more about it.. > > >>>>Or I should do that we everything will be done... > > >>>>Best regards, Nikita > PEAR-QA, Skimming the code, it looks pretty good... already deep into tests and CS too. There are no existing bugs on the old package to use as patch review opportunities. I'm inclined to give a vote of confidence here. -- CRB