Re: Maintenance of Math_Matrix package.

Hi Piran, it's really best that you keep pear-qa CC'd on this - someone else could've answered your mail in the mean-while! Personally, I think it's best to log one bug report per issue - but depending on the size of the attached patches this could get tiresome rather quickly. It would also be good to see someone take over responsibility for Image_Graph ; similarly we would need to see some bug reports and patches for that package too. Many thanks for wanting to contribute to the PEAR community, regards Ken On Thu, Nov 26, 2009 at 12:00 PM, Piran Fletcher <piran@sine-nomine.co.uk> wrote: > In this respect would you like several bug reports with an updated file for > each one or would it be ok to provide a single patch for the bugs I have > encountered so far ? > > In essence the changes are all trivial and are either related to changes to > PHP : > > where php complains about the way result are returned from a function so > assigning the value to be returned to a local var and then returning that > removes the complaints > > Where a reserved word is used : one function is called "clone" and newer > versions of php won't allow that so changing it to matrixClone solves that > one > > there are a couple of typos in the subMatrix function (which I've already > raised a bug report for #16838) > > and perhaps more controversially there is a check in one function that > changes anything smaller than -0.0 to 0 - I'm not sure why but it stops me > when using very small E-6 values. > > I have all these fixed in a single file locally but I can build them > incrementally for each bug report if you like. > > Many thanks > > Piran > > (P.S. I'm also using Image_graph which I also see is not maintained at the > moment so may want to take that one on too) > > -----Original Message----- > From: ken.guest@gmail.com [mailto:ken.guest@gmail.com] On Behalf Of Ken > Guest > Sent: 26 November 2009 11:07 > To: Piran Fletcher > Cc: pear-qa@lists.php.net > Subject: Re: [PEAR-QA] Maintenance of Math_Matrix package. > > On Thu, Nov 26, 2009 at 10:38 AM, Piran Fletcher <piran@sine-nomine.co.uk> > wrote: >> Hello, >> >> I'm developing a website that requires some matrix manipulation and >> have looked at the Math_matrix PEAR package, which is proving very useful. >> Unfortunately there are a couple of bugs in this package and some >> updates to help it work without complaint in PHP 5, as this package is >> currently unmaintained I would like to volunteer to update it. >> > > Hi Piran, > That would be superb - it's always great to see somebody wanting to step up > to the mark ;-) > > What we'd usually need at this stage is for you to submit some bug reports > against Math_matrix along with some patches for it so we can see how well > your coding style matches against the PEAR Standards and so on. It's nothing > complicated and not all that much of  an obstacle to be honest. > > > many thanks > > > Ken > > -- > http://blogs.linux.ie/kenguest/ > > -- http://blogs.linux.ie/kenguest/