Re: Coding Standards and whitespace fixes

Hi Lukas Smith, you wrote:

Matthias Nothhaft wrote:

did anyone thought about a 'PHP_Beautifier' for automagically PEAR CS compliant code cleanup?

Sure, however automagical changes are not what I want to see happen at commit time. My 'automagically' is more a 'by a script' and I see a 'PHP_Beautifier'

as a common tool for people who need a tool to make a script 'human readable' (based on PEAR CS) like XML_Beautifier does it with XML docs. However we can see if we can integrate it more tightly with

the release process. As some of you may have noticed "pear package" throws warnings if you dont prefix things properly. We could have the same for CS violations. However at some point we may also need to be able to specify a list of "I know, but its still right" setting. For example on every MDB release I get a tons of warnings now because of the pear db and metabase wrappers. A 'PHP_Beautifier' could be used as an optional part of packaging

or simply an independant cli tool. It could suggest cs fixes and prompt a 'Yes/No?' for each one. Exeptions could be placed in package.xml !? Or maybe one could 'invent' a comment to mark code that may not be parsed be the beautifier. Another way could also be an optional 'cs.xml'. Regards, Matthias

regards, Lukas Smith PS: Matthias, please dont "top-post". Only inclide the relevant parts of the previous email and put your reply underneath them. PS: fine now?

Maybe one could also write a mail beautifier or a 'reject on mail cs violations' ;-) No, you're always right, Lukas, I was just too lazy...