Re: [pear-webmaster] cvs commit reverted
| From: | Helgi Þormar | Date: | Tue, 11 May 2004 22:48:38 +0000 |
| Subject: | Re: [pear-webmaster] cvs commit reverted | ||
| References: | 1 2 | Groups: | php.pear.webmaster |
| Request: | Send a blank email to pear-webmaster+get-2261@lists.php.net to get a copy of this message | ||
On Tue, 2004-05-11 at 22:33, Daniel Convissor wrote:
> Hi Helgi:
> Ahem. The pear-manual.php commit you made was not my exact patch.
> Perhaps you applied my patch to a file you had already revised? In
> addition, before doing the commit, you made more changes to the file,
> thereby making it impossible to delineate who did what.
>
> All of this was mentioned directly to you and on the pear-cvs list, but no
> reply was received.
>
> Anyway, Martin reverted the commit and I've forwarded him a patch against
> the current file.
>
Bahh your right I made some changes ... but most of them were only
" -> ' (specially since PEARweb shouldn't use " :) talked to pierre
about that issue and he says the same :))
But my humble apology to you dan :) was mixing up file names ;)
Still would be good to get explanation from martin what was wrong ...
since when I look at diff things from what's now and what was when my
and your patches got mixed up ... My stuff it seems is like I said ...
mostly " -> ' changes ... and some bgcolor -> style="background-color"
and such, so no real functinality changes or visual changes from my
side.
--
Regards
Helgi