Re: [pear-webmaster] register_globals
| From: | Daniel Convissor | Date: | Mon, 17 May 2004 13:09:15 +0000 |
| Subject: | Re: [pear-webmaster] register_globals | ||
| References: | 1 2 | Groups: | php.pear.webmaster |
| Request: | Send a blank email to pear-webmaster+get-2380@lists.php.net to get a copy of this message | ||
Hi Toby:
On Mon, May 17, 2004 at 09:28:26AM +0200, Tobias Schlitt wrote:
>
> Sorry, but I'm not aware of it depending on register_globals. Could you
> figure out where exactly?
The one file I noticed it in so far is pepr-proposal-show.php. $id is
used instead of $_GET['id']. Of course, it's easy to fix by adding a one
liner: $id = $_GET['id']. Taking a quick look at other files, I see $id
is used in several other PEPR files as well. There may be other variables
in this boat, but I didn't perform a detailed examination.
Turn register_globals off and you'll find them soon enough. :)
Do note, when $id wasn't set in pepr-proposal-show.php, it redirects
users. But the reidrect went to a non-existant page. I sent a patch for
it to Alan and he applied it. Just making sure you do an update before
continuing work.
Thanks,
--Dan
--
T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y
data intensive web and database programming
http://www.AnalysisAndSolutions.com/
4015 7th Ave #4, Brooklyn NY 11232 v: 718-854-0335 f: 718-854-0409