Bug #1680 [NEW]: Unapproved packages show in package browser

From: demenev at on-line dot jar dot ru Operating system: N/A PHP version: Irrelevant Package: Web Site Bug Type: Bug Bug description: Unapproved packages show in package browser Description: ------------ Package browser ( http://pear.php.net/packages.php ) shows packages which are not yet approved. Provided patch fixes it Reproduce code: --------------- Index: packages.php =================================================================== RCS file: /repository/pearweb/public_html/packages.php,v retrieving revision 1.44 diff -u -r1.44 packages.php --- packages.php 9 Jun 2004 06:14:02 -0000 1.44 +++ packages.php 19 Jun 2004 10:44:43 -0000 @@ -103,7 +103,7 @@ // 1) Show categories of this level $sth = $dbh->query("SELECT c.*, COUNT(p.id) AS npackages FROM categories c LEFT JOIN packages p ON p.category = c.id ". - "WHERE p.package_type = 'pear' AND c.parent $category_where ". + "WHERE p.package_type = 'pear' AND p.approved = 1 AND c.parent $category_where ". "GROUP BY c.id ORDER BY name"); $table = new HTML_Table('border="0" cellpadding="6" cellspacing="2" width="100%"'); @@ -122,6 +122,7 @@ " FROM packages p, categories c". " WHERE c.parent $category_where ". " AND p.package_type = 'pear' ". + " AND p.approved = 1 ". " AND p.category = c.id ORDER BY p.name", false, null, DB_FETCHMODE_ASSOC, true); -- Edit bug report at http://pear.php.net/bugs/bug.php?id=1680&edit=1 --