Re: [pear-webmaster] Re: [PEAR-CVS] cvs: pearweb /public_html/bugs bug.php

On Tue, 2004-06-29 at 18:20, Daniel Convissor wrote: > Hi Helgi: > > On Tue, Jun 29, 2004 at 06:14:04PM -0000, Helgi Þormar Þorbjörnsson wrote: > > dufuz Tue Jun 29 14:14:04 2004 EDT > > > > Modified files: > > /pearweb/public_html/bugs bug.php > ... snip ... > > + echo "<strong>[",format_date($ts),"] "; > > $handle =& $dbh->getOne('SELECT handle FROM users WHERE email = > > '.$dbh->quoteSmart($email).' AND showemail = 0'); > > if (!is_null($handle)) { > > - echo $handle."</b>\n"; > > + echo $handle."</strong>\n"; > > } else { > > echo spam_protect(htmlspecialchars($email))."</b>\n"; > > } > > This protection doesn't seem worth the extra database query. > > If you really want to implement it, do a join to "users" in the first > query and get it over with there. Well this is good enough for now :) Got complaints from users that had their address hidden, will have a better look at this in a moment, but I agree, this is rather lame hack ;) > > --Dan > > PS: Noticed a subsequent commit cought the </b> to </strong> conversion > for the else. > Just did that <b> -> <strong> commit to get the right commit msg :) since I accedently commited bug.php but not search.php like I was going to do. > PPS: So, I guess I don't need to look over those patches you emailed me. > No you don't have to ;) Was impatient.