Re: cvs: pearweb /include/Damblan/RSS PEPr.php

From: Date: Sun, 05 Sep 2004 08:07:43 +0000
Subject: Re: cvs: pearweb /include/Damblan/RSS PEPr.php
References: 1  Groups: php.pear.webmaster 
Request: Send a blank email to pear-webmaster+get-3059@lists.php.net to get a copy of this message
On Sun Sep 05, 2004 at 01:3621AM -0000, Tobias Schlitt wrote: > if (isset($proposalStatiMap[$value])) { > $this->setTitle("PEPr: Latest proposals with status " . > $proposalStatiMap[$value]); > $this->setDescription("The latest PEPr proposals with status " . > $proposalStatiMap[$value]); > } else { > $this->setTitle("PEPr: Latest proposals."); > $this->setDescription("The latest PEPr proposals."); > $value = null; > } Shouldn' we change this to if (isset($proposalStatiMap[$value])) { /* ... */ } else if (empty($value)) { /* ... */ } else { PEAR::raiseError("The requested URL " . $_SERVER['REQUEST_URI'] . " was not found on this server."); } ? Allowing each and every /feeds/pepr_*.rss URL to return something meaningful isn't very deterministic. -- - Martin Martin Jansen http://martinjansen.com/

« previous php.pear.webmaster (#3059) next »