Re: [pear-webmaster] Re: [PEAR-CVS] cvs: pearweb /include pear-database.php
| From: | Helgi Þormar | Date: | Mon, 04 Oct 2004 19:20:07 +0000 |
| Subject: | Re: [pear-webmaster] Re: [PEAR-CVS] cvs: pearweb /include pear-database.php | ||
| References: | 1 2 | Groups: | php.pear.webmaster php.pear.core |
| Request: | Send a blank email to pear-webmaster+get-3219@lists.php.net to get a copy of this message | ||
On Mon, 2004-10-04 at 19:01, Daniel Convissor wrote:
> On Mon, Oct 04, 2004 at 06:11:15PM -0000, Helgi Þormar Þorbjörnsson wrote:
> > dufuz Mon Oct 4 14:11:15 2004 EDT
> >
> > renamed getZendWhoIsWho to getWhoIsWho since this function could be
> > used by more sites then Zend, and also removed Zend's ip from the
> > whitelist and removed that silly return false
>
> I thought this was being discussed by the Group. Has a decision
> been reached? I didn't seen an announcement of such.
>
> In addition, from what I recall of discussions on the pear webmaster
> list, only permitted companies/organizations/sites were going to be
> granted access to the procedure. So, removing the IP address seems
> ill advised.
>
> --Dan
So you think disabling the function with return false is better then
using it's already coded function to not allow things to slip in, why do
you think that whitelist was made ?
Kinda stupid making a whitelist with IP addresses, and then closing the
function down with return false, thus giving errors to (in this examples
Zend) the websites that are connection to this, specially since it
should return array, which had been okey if it had done return array()
not return false, comes down to the same remove the return false and the
IP address.
Regarding the renaming, this function can be used by others then Zend,
so why not change it ?
If the group has decided something or not shouldn't affect this, it's
purely to reflect what the function does and can do.
As you can clearly see I'm not giving no one access to any info with
those changes, only removing zend IP, which was actually requested by a
send employee, until this issue has been resolved, and also since it has
been agreed on allowing Zend to get a stripped down version of user
info, so this is only the first step in getting that in, but since the
filter/stripped down version isn't implanted, then Zend won't have
anything to do with a access to that function.
(stripped down, would mean, name, handle and which package the user is
maintainer of)
Hopefully this will clear things up for you and the rest of the people,
if suddenly everything change, then no harm has been done since, like I
said no one has access to that function unless locally from that
machine, and now the function returns right type.
Regards
Helgi