Re: cvs: pearweb /cron bug-summary.php

On Thu, 2004-11-18 at 17:34, Martin Jansen wrote: > On Wed Nov 17, 2004 at 02:0336PM -0000, Helgi Þormar Þorbjörnsson wrote: > > require_once dirname(__FILE__) . '/../include/pear-config.php'; > > require_once dirname(__FILE__) . '/../public_html/bugs/include/functions.inc'; > > Is there any reason why $root/public_html/bugs/include isn't > $root/include/bugs? No daniel changed it to the old way, and I had no objection, and no one else it seems at the time :) > > b.package_name IN ('". implode("', '", > > $pseudo_pkgs) . "')) > > The website is following the PEAR coding standards, thus you should > separate the concatenation operators with spaces. Well it isn't much followed IMHO the CS in PEARWeb (which has been changing though, which is good), but sure it was my mistake :) will fix > > mail('pear-qa@lists.php.net', $siteBig.' Bug Summary Report', > > $body, 'From: pear-dev@lists.php.net'); > > I believe we should use "From: pear-qa@lists.php.net" instead. And > please pass '-f pear-sys@php.net' as the fifth parameter for mail(). Yes I wasn't sure with the -f, forgot to ask this, but this is a very much appreciated feedback :) Regarding the pear-dev vs. pear-qa, I was just keeping this in sync with the rest of the bug system, and there we use pear-dev, maybe we should change everything to pear-qa in the bug system ? Also do you mean the per package email should be from pear-qa, or just the bug summary ? Anyway committed the changes Regards Helgi