patches for http://pear.php.net/bugs/bug.php?id=103

From: Date: Sun, 13 Mar 2005 14:00:04 +0000
Subject: patches for http://pear.php.net/bugs/bug.php?id=103
Groups: php.pear.webmaster 
Request: Send a blank email to pear-webmaster+get-3965@lists.php.net to get a copy of this message
Hello pear-webmaster, With the help of Richard Heyes I've made two patches to solve problem with Edit Maintainers in some browsers. I hope somebody with appropriate karma can commit these. -- anatoly

--- package-maintainers_old.js 2005-02-19 02:34:58.000000000 +0200 +++ package-maintainers.js 2005-03-13 15:36:00.000000000 +0200 @@ -36,7 +36,7 @@ role = getRole(); handle = document.form.accounts.options[i].value; value = handle + "||" + role; - item = new Option(name + " (" + handle + ", " + role + ")", value); + item = new Option(name + " (" + handle + ", " + role + ")", value, false, true); document.form['maintainers[]'].options[document.form['maintainers[]'].length] = item; } } @@ -61,6 +61,7 @@ for (i = 0; i < document.form['maintainers[]'].length; i++) { field = document.form['maintainers[]'].options[i].selected = true; } + return true; } function activateAdd() { --- package-maintainers_old.php 2005-02-19 02:34:52.000000000 +0200 +++ package-maintainers.php 2005-03-13 15:14:06.000000000 +0200 @@ -110,13 +110,13 @@ echo ' </td>'; echo ' <td>'; - echo ' <input type="submit" onClick="addMaintainer(); return false" name="add" value="Add as" />'; + echo ' <input type="button" onClick="addMaintainer();" name="add" value="Add as" />'; echo ' <select name="role" size="1">'; echo ' <option value="lead">lead</option>'; echo ' <option value="developer">developer</option>'; echo ' <option value="helper">helper</option>'; echo ' </select><br /><br />'; - echo ' <input type="submit" onClick="removeMaintainer(); return false" name="remove" value="Remove" />'; + echo ' <input type="button" onClick="removeMaintainer();" name="remove" value="Remove" />'; echo ' </td>'; echo ' <td>';
« previous php.pear.webmaster (#3965) next »