Bug #103 [Asn->Csd]: Edit Maintainers broken

Edit report at http://pear.php.net/bugs/bug.php?id=103&edit=1 ID: 103 Updated by: mj@php.net Reported By: thesaur at php dot net -Status: Assigned +Status: Closed Type: Bug Package: Web Site Operating System: Irrelevant PHP Version: Irrelevant Assigned To: mj New Comment: This bug has been fixed in CVS. In case this was a documentation problem, the fix will show up at the end of next Sunday (CET) on pear.php.net. In case this was a pear.php.net website problem, the change will show up on the website in short time. Thank you for the report, and for helping us make PEAR better. Previous Comments: ------------------------------------------------------------------------ [2005-05-30 03:50:17] techtonik at php dot net Here you are. public_html/javascript/package-maintainers.js http://www.megaupload.com/?d=045XQJH3 public_html/admin/package-maintainers.php http://www.megaupload.com/?d=04Z0SSHM ------------------------------------------------------------------------ [2005-05-25 06:00:51] pierre at dotgeek dot org Please provide a link to the patch. Doing so will help for other people to test your patch and/or apply if everything works fine. Thanks for it btw :) --Pierre ------------------------------------------------------------------------ [2005-05-25 03:48:10] techtonik at php dot net Martin, have you received the patches I mailed you? ------------------------------------------------------------------------ [2005-03-31 06:50:03] techtonik at php dot net Here is the second part. For pearweb\public_html\javascript\package-maintainers.js --- package-maintainers_old.js 2005-02-19 02:34:58.000000000 +0200 +++ package-maintainers.js 2005-03-13 15:36:00.000000000 +0200 @@ -36,7 +36,7 @@ role = getRole(); handle = document.form.accounts.options[i].value; value = handle + "||" + role; - item = new Option(name + " (" + handle + ", " + role + ")", value); + item = new Option(name + " (" + handle + ", " + role + ")", value, false, true); document.form['maintainers[]'].options[document.form['maintainers[]'].length] = item; } } @@ -61,6 +61,7 @@ for (i = 0; i < document.form['maintainers[]'].length; i++) { field = document.form['maintainers[]'].options[i].selected = true; } + return true; } function activateAdd() { ------------------------------------------------------------------------ [2005-03-13 08:55:20] techtonik at php dot net Here are two patches, which can solve the problem Patch for pearweb\public_html\admin\package-maintainers.php --- package-maintainers_old.php 2005-02-19 02:34:52.000000000 +0200 +++ package-maintainers.php 2005-03-13 15:14:06.000000000 +0200 @@ -110,13 +110,13 @@ echo ' </td>'; echo ' <td>'; - echo ' <input type="submit" onClick="addMaintainer(); return false" name="add" value="Add as" />'; + echo ' <input type="button" onClick="addMaintainer();" name="add" value="Add as" />'; echo ' <select name="role" size="1">'; echo ' <option value="lead">lead</option>'; echo ' <option value="developer">developer</option>'; echo ' <option value="helper">helper</option>'; echo ' </select><br /><br />'; - echo ' <input type="submit" onClick="removeMaintainer(); return false" name="remove" value="Remove" />'; + echo ' <input type="button" onClick="removeMaintainer();" name="remove" value="Remove" />'; echo ' </td>'; echo ' <td>'; ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://pear.php.net/bugs/bug.php?id=103 -- Edit this bug report at http://pear.php.net/bugs/bug.php?id=103&edit=1