Re: [pear-webmaster] Re: [PEAR-CORE] cvs: pearweb /public_html account-edit.php /sql users.sql
| From: | Martin Jansen | Date: | Tue, 25 Oct 2005 11:52:32 +0000 |
| Subject: | Re: [pear-webmaster] Re: [PEAR-CORE] cvs: pearweb /public_html account-edit.php /sql users.sql | ||
| References: | 1 2 3 | Groups: | php.pear.webmaster |
| Request: | Send a blank email to pear-webmaster+get-4566@lists.php.net to get a copy of this message | ||
On Tue Oct 25, 2005 at 11:4644AM +0000, Helgi Þormar wrote:
> On Tue, 25 Oct 2005 12:39:51 +0200, Martin Jansen wrote:
>
> > On Tue Oct 25, 2005 at 01:1301AM -0000, Helgi Þormar Þorbjörnsson wrote:
> >> + if ($k == 'userinfo' && strlen($user_data_post[$k])
> >> > '255') {
> >
> > The return value of strlen() is int, not string.
>
> And since when was PHP a strict type language? This works perfectly.
Just because something works does not imply that it is also correct.
> > I suggest we use "characters" instead of "chars", and to some extent I
> > agree with Daniel that 255 is a bit too small. Right now 97 users have
> > more than 255 characters in their userinfo field, but only 18 of them
> > go above 500, which is why I'd prefer to go for a limit of 500
> > characters.
>
> I see no real reason why people should need over 255 chars, if you want to
> support 500 then you may go ahead and change it to that limit, as to the
> chars vs. characters, these are coders we are dealing with, they will
> understand both :-) But if you find it better to use the long version then
> also by all means change it.
Done.
- Martin