Re: Mail class in pear

Hello Chuck, On Tue, Oct 03, 2000 at 10:47 -0400, Chuck Hagenbuch wrote: > > Quoting Leo <leonard.west@afp.com>: > > > I wrote a Mail component i'd like programmer to review, so that i could be integrated > > in Pear. > > > > It can be found with documentation at > > http://lwest.free.fr/doc/php/lib/Mail/?lang=en > > A couple of things: > 1. You don't need to call mail() once for each recipient. > 2. Relying on php's mail() function means that you can't set the envelope > properly, which means that mailing lists that check the sender address in > the envelope won't accept mails from your script, among other things. Also, > errors may go to the wrong address. > 3. There's no seperation between the code to create the message itself, and > the code to send the message. These can be entirely seperate, and _should_ > be, to allow multiple sending backends (smtp, sendmail, mail(), etc) and > even frontends (one to specifically generate multipart/alternative, etc). Yup. And there should be support of Base64/Quoted-Printable and multiple charsets. I'd suggest the 'recode' extension for that. > 4. The code doesn't follow PEAR coding standards. Where one might get accustomed to these? I mean the paper, not the staring at code. -- Stay tuned, MhZ mailto:mookid@sigent.ru ----------- The wages of sin are high but you get your money's worth.