Re: Commit

Quoting Sean Grimes <metallic@noworlater.net>: > I just commited the rendering class to XML/Render/render.php. Out of curiosity, why is it in a subdirectory, instead of XML/Render.php, and why does the classname not match where it is? From where it is, it should be class XML_Render_render; from our standards, it should be XML/Render/Render.php (capitalize the first letter of each word, and all of acronyms). I think XML_Render (with the filename XML/Render.php) is a better choice. Also, if you end up adding subclasses, _they_ could go in XML/Render/, with classnames like XML_Render_HTML, XML_Render_PDF, etc... Yes, I pick nits. But if one of the goals of PEAR is consistency, then someone has to watch out for it. -chuck -- Charles Hagenbuch, <chuck@horde.org> "If you can't stand the heat, get out of the chicken!" - Baby Blues