Re: com web/pecl: check for the LICENSE or COPYING presence in tarballs: public_html/release-upload.php

On Sun, Oct 13, 2013 at 3:57 AM, Anatol Belski <ab@php.net> wrote: > Commit: f49cf969de7ff71fbd96b5814cc0ca8695c9b0b5 > Author: Anatol Belski <ab@php.net> Sun, 13 Oct 2013 12:57:33 +0200 > Parents: 78cc88deae3cdce68ddab5ac035bdb76122986e2 > Branches: old_auth > > Link: > http://git.php.net/?p=web/pecl.git;a=commitdiff;h=f49cf969de7ff71fbd96b5814cc0ca8695c9b0b5 > > Log: > check for the LICENSE or COPYING presence in tarballs > > Changed paths: > M public_html/release-upload.php > > > Diff: > diff --git a/public_html/release-upload.php b/public_html/release-upload.php > index 221f941..ffc8842 100644 > --- a/public_html/release-upload.php > +++ b/public_html/release-upload.php > @@ -89,8 +89,27 @@ do { > $errors[] = 'package.xml v1 format is not supported anymore, please update > your package.xml to 2.0. '; > break; > } > - $display_form = false; > - $display_verification = true; > + > + $license_found = false; > + foreach ($info->getFileList() as $file_name => $file_data) { > + if ("doc" != $file_data["role"]) { > + continue; > + } > + > + /* Don't compare with basename($file_data["name"]), the license > has > + to be in the package root. */ > + if (in_array($file_data["name"], array("LICENSE", > "COPYING"))) { > + $license_found = true; Is there a reason for a explicit check of these file names? What if it ends in .txt, .md, .rst, .html, .ps, .doc or whatever? Also, this is a epic change in uploading releases procedures and requires a gigantic notice and weeks of headsup to all pecl ext authors. Please revert this asap so people can continue uploading their releases. We need to give people time to adjust. -Hannes